Housekeeping #136
Housekeeping #136
Conversation
|
☔ The latest upstream changes (presumably #135) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
r=me |
We've migrated to GitHub Actions and it seems that Cargo.toml badges are deprecated in favour of rendering READMEs directly: rust-lang/crates.io#2436
|
@bors r=Manishearth |
|
@Xanewok: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r+ |
|
📌 Commit 3550a9a has been approved by |
Housekeeping Fixing some artifacts of the past - this should not change any behaviour. It's worth noting that there are some `allow` attributes for pedantic Clippy lints, which are not enforced anywhere anymore - probably because those lints have been moved around in categories. Should I remove the directives that do not warn anymore by default under `cargo clippy`? r? `@Manishearth`
|
@Mark-Simulacrum can you add @Xanewok and @ibabushkin as reviewers to this? It's fine to set this up as some sort of "semverver project group" under devtools too if necessary. |
|
💥 Test timed out |
|
I think someone else added those permissions? Uncertain. |
|
I added permissions manually in rust-lang/team#472 but maybe we should set up a separate project group as well. It seems I need to add CI triggers for the |
|
Let's try this again @bors retry |
|
☀️ Test successful - checks-actions |
Fixing some artifacts of the past - this should not change any behaviour.
It's worth noting that there are some
allowattributes for pedantic Clippy lints, which are not enforced anywhere anymore - probably because those lints have been moved around in categories. Should I remove the directives that do not warn anymore by default undercargo clippy?r? @Manishearth