Subtree update of `rust-analyzer` #142907

lnicola · 2025-06-23T10:44:09Z

…hen possible But default to not to. I chose to have a more generic config name because maybe other assists could also use the same approach.

…private-field diagnostic (previously it was only on no-such-field) The difference between the diagnostics is that no-such-field is for record struct construction, while private-field is for dot syntax. I tried to unify them, but there is a bit of uniqueness in each. This is possible but maybe not worth it. Also, fix the quickfix when there is already a visibility to the field (replace it instead of appending to it).

feat: Show what cargo metadata is doing in status

feat: Insert required parentheses when typing `+` in dyn trait type

…data`

…-quickfix feat: Add the quickfix for increasing visibility of a private field to the private-field diagnostic (previously it was only on no-such-field)

feat: In "Fill match arms", allow users to prefer `Self` to the enum name when possible

fix: Copy lockfiles into target directory before invoking `cargo metadata`

chore: Start infesting ide crates with 'db lifetime

fix: Reload workspaces when cargo configs change

We show fixes now even for experimental diagnostics anyway, and it has false positives.

…-exp fix: Never make type mismatch diagnostic stable, even when there is a fix

Improve completions in if / while expression conditions

…s_without_pe Hide imported privates if private editable is disabled

minor: Sync from downstream

Fixes rust-lang/rust-analyzer#20030

fix: Closure capturing for let exprs

This reverts commit 8643a858dbaf12b37e90b603cdee64434576c229.

Revert "Turn `BlockId` into a `#[salsa::tracked]`"

…sition

fix: Temporarily disable `+` typing handler as it moves the cursor position

Add --color=always to test explorer command

…getter Add `fn parent(self, db) -> GenericDef` to `hir::TypeParam`

fix: Correct grammar in remove all unused imports assist

internal: Utilize `cargo check --compile-time-deps`

…de-imports-in-symbol-search Add better documentation for excluding imports from symbol search

Minic rustc's new `format_args!` expansion

rustbot · 2025-06-23T10:44:14Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2025-06-23T10:44:19Z

@bors r+ p=1 subtree sync

bors · 2025-06-23T10:44:22Z

📌 Commit 9a0434e has been approved by lnicola

It is now in the queue for this repository.

bors · 2025-06-23T15:57:43Z

⌛ Testing commit 9a0434e with merge 706f244...

bors · 2025-06-23T19:23:45Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 706f244 to master...

github-actions · 2025-06-23T19:26:30Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 42245d3 (parent) -> 706f244 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 706f244db581212cabf2e619e0113d70999b2bbe --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8136.9s -> 11631.9s (43.0%)
aarch64-apple: 5990.8s -> 3917.0s (-34.6%)
x86_64-apple-1: 9679.7s -> 6583.5s (-32.0%)
mingw-check-1: 1815.1s -> 1523.8s (-16.0%)
dist-aarch64-apple: 7305.7s -> 6240.0s (-14.6%)
x86_64-apple-2: 5544.2s -> 4938.9s (-10.9%)
x86_64-gnu-llvm-20-1: 3616.8s -> 3266.1s (-9.7%)
i686-gnu-2: 6097.6s -> 5511.3s (-9.6%)
i686-gnu-1: 7968.0s -> 7213.0s (-9.5%)
x86_64-gnu-miri: 5084.9s -> 4619.3s (-9.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-24T00:54:41Z

Finished benchmarking commit (706f244): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.4%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.0%, 1.8%]	3
Regressions ❌ (secondary)	1.6%	[1.3%, 1.9%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[1.0%, 1.8%]	3

Cycles

Results (primary 1.4%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	2.9%	[1.9%, 6.4%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 688.878s -> 688.989s (0.02%)
Artifact size: 371.92 MiB -> 371.96 MiB (0.01%)

ChayimFriedman2 and others added 30 commits June 6, 2025 16:34

In "Fill match arms", allow users to prefer Self to the enum name w…

2a473e5

…hen possible But default to not to. I chose to have a more generic config name because maybe other assists could also use the same approach.

feat: Show what cargo metadata is doing in status

13f5866

Merge pull request rust-lang#20014 from Veykril/push-lsqvxunvnrqw

233e1a8

feat: Show what cargo metadata is doing in status

feat: Insert required parentheses when typing + in trait type

a38a9a6

Merge pull request rust-lang#20015 from Veykril/push-wsxzsuurqwwr

cc8cf56

feat: Insert required parentheses when typing `+` in dyn trait type

fix: Copy lockfiles into target directory before invoking `cargo meta…

703856f

…data`

Merge pull request rust-lang#19945 from ChayimFriedman2/private-field…

e4e01f6

…-quickfix feat: Add the quickfix for increasing visibility of a private field to the private-field diagnostic (previously it was only on no-such-field)

Merge pull request rust-lang#19939 from ChayimFriedman2/fill-arms-self

3b9ef28

feat: In "Fill match arms", allow users to prefer `Self` to the enum name when possible

Merge pull request rust-lang#20018 from Veykril/push-pkowrtoturkr

69886cf

fix: Copy lockfiles into target directory before invoking `cargo metadata`

chore: Start infesting ide crates with 'db lifetime

8e86b84

Merge pull request rust-lang#19495 from Veykril/push-woywmrxrtqqy

c860169

chore: Start infesting ide crates with 'db lifetime

fix: Reload workspaces when cargo configs change

7d10a14

Merge pull request rust-lang#20020 from Veykril/push-yuqmorzsqumw

3341b65

fix: Reload workspaces when cargo configs change

Never make type mismatch diagnostic stable, even when there is a fix

a1aac53

We show fixes now even for experimental diagnostics anyway, and it has false positives.

Merge pull request rust-lang#20022 from ChayimFriedman2/type-mismatch…

e0c5fcb

…-exp fix: Never make type mismatch diagnostic stable, even when there is a fix

Improve completions in if / while expression conditions

646fecf

Better completion test sorting

7ba853c

Merge pull request rust-lang#20023 from Veykril/push-vkqlnyttnqzl

5f2cf7e

Improve completions in if / while expression conditions

Hide imported privates if private editable is disabled

1f24f02

Merge pull request rust-lang#20025 from SoxPopuli/hide_private_import…

20a62ab

…s_without_pe Hide imported privates if private editable is disabled

Preparing for merge from rust-lang/rust

5d1a869

Merge from rust-lang/rust

96e1d73

Merge pull request rust-lang#20032 from lnicola/sync-from-rust

e7971e4

minor: Sync from downstream

Add --color=always to test explorer command

b4f09d7

Fixes rust-lang/rust-analyzer#20030

fix: Closure capturing for let exprs

70f376d

Merge pull request rust-lang#20039 from ShoyuVanilla/let-bind-ref-capt

58d4b99

fix: Closure capturing for let exprs

Revert "Turn BlockId into a #[salsa::tracked]"

d41f48f

This reverts commit 8643a858dbaf12b37e90b603cdee64434576c229.

Merge pull request rust-lang#20041 from Veykril/push-yxlszoznuyno

dd8eaaa

Revert "Turn `BlockId` into a `#[salsa::tracked]`"

fix: Temporarily disable + typing handler as it moves the cursor po…

80bd8a4

…sition

Veykril and others added 13 commits June 19, 2025 06:40

Merge pull request rust-lang#20042 from Veykril/push-uosxynulorzn

b8cc805

fix: Temporarily disable `+` typing handler as it moves the cursor position

Add fn parent(self, db) -> GenericDef to hir::TypeParam

7785869

Merge pull request rust-lang#20035 from joshka/jm/test-explorer-color

2a6ace3

Add --color=always to test explorer command

Merge pull request rust-lang#20046 from regexident/type-param-parent-…

808e066

…getter Add `fn parent(self, db) -> GenericDef` to `hir::TypeParam`

Add better documentation for excluding imports from symbol search

af3f9d1

internal: Utilize cargo check --compile-time-deps

8329c93

fix: Correct grammar in remove all unused imports assist

29a8b83

Merge pull request rust-lang#20053 from ze/master

9d76126

fix: Correct grammar in remove all unused imports assist

Merge pull request rust-lang#20047 from ShoyuVanilla/comp-time-deps

110bacd

internal: Utilize `cargo check --compile-time-deps`

Merge pull request rust-lang#20050 from LHolten/better-docs-for-exclu…

3fb8acb

…de-imports-in-symbol-search Add better documentation for excluding imports from symbol search

Implement region negation to minicore and add a flag fmt_before_1_89_0

17a8ba9

Minic rustc's new format_args! expansion

03a8268

Merge pull request rust-lang#20056 from ShoyuVanilla/fmt-args-new

9a0434e

Minic rustc's new `format_args!` expansion

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2025

bors merged commit 706f244 into rust-lang:master Jun 23, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jun 23, 2025

lnicola deleted the sync-from-ra branch June 24, 2025 04:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Subtree update of `rust-analyzer` #142907

Subtree update of `rust-analyzer` #142907

Uh oh!

lnicola commented Jun 23, 2025

Uh oh!

rustbot commented Jun 23, 2025

Uh oh!

lnicola commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

rust-timer commented Jun 24, 2025

Uh oh!

Uh oh!

Subtree update of rust-analyzer #142907

Subtree update of rust-analyzer #142907

Uh oh!

Conversation

lnicola commented Jun 23, 2025

Uh oh!

rustbot commented Jun 23, 2025

Uh oh!

lnicola commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 23, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 24, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Subtree update of `rust-analyzer` #142907

Subtree update of `rust-analyzer` #142907