Port #[export_name] to the new attribute parsing infrastructure
#142986
+215
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs |
9 tasks
jdonszelmann
requested changes
Jun 24, 2025
There was a problem hiding this comment.
I'll sequence this after #142825 which likely needs a rebase anyway. I like the impl, just some minor things.
rustbot
added
S-waiting-on-author
JonathanBrouwer
force-pushed
the
export_name_parser
branch
from
83731a6 to
85108ca
Compare
|
^ Rebased & fixed feedback |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 25, 2025
…, r=jdonszelmann Port `#[export_name]` to the new attribute parsing infrastructure This PR contains two changes, in separate commits for reviewability: - Ports `export_name` to the new attribute parsing infrastructure for rust-lang#131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax r? `@jdonszelmann`
Urgau
reviewed
Jun 25, 2025
|
@bors r- |
bors
added
S-waiting-on-author
JonathanBrouwer
force-pushed
the
export_name_parser
branch
from
85108ca to
8d80099
Compare
|
^ Fixed the comment above |
rustbot
added
S-waiting-on-review
|
Will likely fail ci after the merges from yesterday fyi |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jonathan Brouwer <[email protected]>
…he error Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
export_name_parser
branch
from
8d80099 to
3d1cee5
Compare
|
Well predicted :P I'll fix the other PRs in a bit |
|
@bors r+ |
bors
added
S-waiting-on-bors
This was referenced Jun 26, 2025
bors
added a commit
that referenced
this pull request
Jun 27, 2025
…rors Rollup of 18 pull requests Successful merges: - #137843 (make RefCell unstably const) - #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142927 (Add note to `find_const_ty_from_env`) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition) - #142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143033 (Expand const-stabilized API links in relnotes) - #143041 (Remove cache for citool) - #143056 (Move an ACE test out of the GCI directory) - #143059 (Fix 1.88 relnotes) - #143067 (Tracking issue number for `iter_macro`) - #143073 (Fix some fixmes that were waiting for let chains) Failed merges: - #143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 27, 2025
Rollup merge of #142986 - JonathanBrouwer:export_name_parser, r=jdonszelmann Port `#[export_name]` to the new attribute parsing infrastructure This PR contains two changes, in separate commits for reviewability: - Ports `export_name` to the new attribute parsing infrastructure for #131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax r? ``@jdonszelmann``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes, in separate commits for reviewability:
export_nameto the new attribute parsing infrastructure for Tracking issue: Attribute refactor #131229 (comment)r? @jdonszelmann