Use cargo run in more places #16732
Closed
Use cargo run in more places #16732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the parser understand trailing commas in method calls, method definitions, enum variants, and type parameters. Closes rust-lang#14240. Closes rust-lang#15887.
Current version of rust fails when casting from bool, e.g.
```rust
fn main() {
let _a = false as uint;
let _b = true as uint;
let _c: [bool, ..false as uint];
let _d: [bool, ..true as uint];
// _a and _b work, but _c and _d result in an error
// error: expected constant expr for vector length: can't cast str to uint
}
```
This commit makes it work as expected.
…richton This lets the parser understand trailing commas in method calls, method definitions, enum variants, and type parameters. Closes rust-lang#14240. Closes rust-lang#15887.
…hton Shows linker spew even when linking succeeds. This is occasionally useful in order to see verbose linker output.
This commits implements {Tcp,Unix}Acceptor::{clone,close_accept} methods for
unix. A windows implementation is coming in a later commit.
The clone implementation is based on atomic reference counting (as with all
other clones), and the close_accept implementation is based on selecting on a
self-pipe which signals that a close has been seen.
This commits implements {Tcp,Unix}Acceptor::{clone,close_accept} methods for
all of librustuv.
This implementation rewrites much of Access, AccessTimeout, and AcceptTimeout to
have type parameter for shared state that all acceptors share (a shared queue of
sockets). The incoming/outgoing channels have been removed as all timeouts and
such are now managed on the event loop rather than concurrently.
This commit implements TcpAcceptor::{close, close_accept} for windows via
WSAEVENT types.
Document the new code for how close_accept and timeouts are implemented.
This commits takes a similar strategy to the previous commit to implement close_accept and clone for the native win32 pipes implementation. Closes rust-lang#15595
If a task is spinning in an accept loop, there is currently no method of gracefully shutting it down. This PR introduces a way to do so by cloning the acceptor and implementing a close_accept method to unblocking any pending acceptor. As with other I/O methods like this, it is `#[experimental]` from the start and sadly carries with it a good deal of code to support it. Much of the complication is from the fact that you can now concurrently accept on the same socket. I tried to add a good deal of tests for this change, but another set of eyes is always appreciated!
Closes rust-lang#8492. I did not find this suggestion in the [guidelines][] but it's mentioned in the [old style guide][]. [guidelines]: https://github.com/rust-lang/rust-guidelines [old style guide]: https://github.com/rust-lang/rust/wiki/Note-style-guide/73c864a10a8e231e2a6630e5a3461f1d3022a20a
|
r @steveklabnik ? |
| ```{notrust,ignore} | ||
| $ ./target/guessing_game | ||
| $ cargo run | ||
| Compiling guessing_game v0.1.0 (file:/home/you/projects/guessing_game) |
There was a problem hiding this comment.
Is this accurate? I thought file:/// was the way now.
|
Thanks! Sorry, didn't get to this yet. One quick question, but otherwise looks good. |
|
Whoah, why are you deleting this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cargo run instead of cargo build where possible...