Rollup of PRs in the queue; Monday #23219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're opt-in now. Fixes rust-lang#22572
If we end the `scoped` call with a semicolon, the `JoinGuard` will be dropped and not returned from the `map`. The thread will start up and we immediately block, making for a very expensive sequential loop.
A minor change to avoid making the reader think 'where is this'.
rustc will ICE if you specify an outfile path that is bare without a directory. As a workaround, before this -o ./foo will work
|
@bors: r+ p=20 |
|
|
…richton Motivated by the test output not lining up when it could, I normalized all of the issue-* tests. While doing it, I found some lexer tests that could be unignored and fixed an int -> isize.
rustc will ICE if you specify an outfile path that is bare without a directory. As a workaround, before this -o ./foo will work It wasn't clear to me where I could put a test that actually invokes rustc from a shell, although I think I can add doctests to that machinery in librustc_driver that will arrange for this to be called with arguments that would trigger the ICE
in the [doc page](http://doc.rust-lang.org/std/num/index.html), `FromStrRadix::from_str_radix` is not quoted.
They're opt-in now. Fixes rust-lang#22572
…rent, r=steveklabnik If we end the `scoped` call with a semicolon, the `JoinGuard` will be dropped and not returned from the `map`. The thread will start up and we immediately block, making for a very expensive sequential loop.
A minor change to avoid making the reader think 'where is this'.
|
@bors: r+ force |
|
⌛ Testing commit f3c427c with merge efc4ec3... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
|
@bors: r+ |
bors
added a commit
that referenced
this pull request
Mar 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.