Rollup of PRs in the queue; Tuesday #23436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[breaking-change] Closes rust-lang#23266
To the correct MAP_NORESERVE. Every other thing is known as MAP_NORESERVE, so this is just a basic typo. I really doubt this will break anybody's but my own code.
This removes the error case of the compression functions, the only errors that can occur are incorrect parameters or an out-of-memory condition, both of which are handled with panics in Rust. Also introduces an extensible `Error` type instead of returning an `Option`.
The [associated RFC][rfc] for possibly splitting out `flush` has been closed and as a result there are no more blockers for stabilizing this method, so this commit marks the method as such. [rfc]: rust-lang/rfcs#950
This looks like the most logical target to give to this link, or at least what I would expect as someone that want to integrate with a native library. r? @steveklabnik
Also: - italize the binding name - complete a sentence
The word 'flush' may be misinterpreted as if `flush` is called on the underlying writer, which is not the case.
This removes the error case of the compression functions, the only errors that can occur are incorrect parameters or an out-of-memory condition, both of which are handled with panics in Rust. Also introduces an extensible `Error` type instead of returning an `Option`. The type implements a destructor so you can't destructure it.
To the correct MAP_NORESERVE. Every other instance is known as MAP_NORESERVE, so this is just a basic typo. I really doubt this will break anybody's but my own code. [breaking-change]
The [associated RFC][rfc] for possibly splitting out `flush` has been closed and as a result there are no more blockers for stabilizing this method, so this commit marks the method as such. [rfc]: rust-lang/rfcs#950
This looks like the most logical target to give to this link, or at least what I would expect as someone that want to integrate with a native library. r? @steveklabnik
…eveklabnik Also: - italize the binding name - complete a sentence
As suggested by @steveklabnik in rust-lang#23254, I removed the redundant Rust syntax highlighting from the documentation.
…ichton r? @alexcrichton Conflicts: src/test/run-pass/test-fn-signature-verification-for-explicit-return-type.rs
…crichton Resolves rust-lang#23386.
|
@bors: r+ p=20 |
bors
added a commit
that referenced
this pull request
Mar 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.