Fix variance ordering #27525
Merged
Fix variance ordering #27525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ rollup |
|
📌 Commit 70f4da9 has been approved by |
| @@ -93,8 +93,8 @@ fn main() { | |||
|
|
|||
| The signature of `overwrite` is clearly valid: it takes mutable references to | |||
| two values of the same type, and overwrites one with the other. If `&mut T` was | |||
| variant over T, then `&mut &'a str` would be a subtype of `&mut &'static str`, | |||
| since `&'a str` is a subtype of `&'static str`. Therefore the lifetime of | |||
| variant over T, then `&mut &'a static` would be a subtype of `&mut &'a str`, | |||
|
@bors r- |
I thought this was actually a huge error and I'd have to rewrite a bunch but it looks like everything else was correct. Closes rust-lang#27457
|
@bors r=aturon |
|
📌 Commit 67455e2 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 5, 2015
I thought this was actually a huge error and I'd have to rewrite a bunch but it looks like everything else was correct. Closes rust-lang#27457 r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was actually a huge error and I'd have to rewrite a bunch but
it looks like everything else was correct.
Closes #27457
r? @aturon