Fix some grammar in The Advanced Rust Programming Language #27527
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Wow, thanks! |
| happen. Data accesses are very friendly to the hardware and compiler, but as | ||
| we've seen they offer *awful* semantics to try to write synchronized code with. | ||
| we've seen they offer *awful* semantics with which to try to write synchronized code. |
There was a problem hiding this comment.
While general grammar fixes are appreciated, this precise from of pedantry is up with which the Rust project will not put. 😸
There was a problem hiding this comment.
I'm generally not that pedantic either. Reverted.
|
r=me with the single nit addressed. |
|
LGTM, just need the commits to be squashed. |
|
Done |
|
@bors r+ rollup Thanks! |
|
📌 Commit 2accd29 has been approved by |
Just some grammar fixes and an assumed missing word. r? @gankro
Just some grammar fixes and an assumed missing word.
r? @gankro