Thread docs fix and improvements. #43619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuietMisdreavus
previously requested changes
Aug 3, 2017
src/libstd/thread/mod.rs
Outdated
| @@ -834,6 +835,9 @@ pub fn park_timeout(dur: Duration) { | |||
| /// let other_thread_id = other_thread.join().unwrap(); | |||
| /// assert!(thread::current().id() != other_thread_id); | |||
| /// ``` | |||
| /// | |||
| //! [`id`]: ../../std/thread/struct.Thread.html#method.id | |||
| //! [`Thread`]: ../../std/thread/struct.Thread.html | |||
src/libstd/thread/mod.rs
Outdated
| @@ -896,6 +900,9 @@ struct Inner { | |||
| /// docs of [`Builder`] and [`spawn`] for more details. | |||
| /// | |||
| /// [`Builder`]: ../../std/thread/struct.Builder.html | |||
| //! [`JoinHandle::thread`]: ../../std/thread/struct.JoinHandle.html#method.thread | |||
| //! [`JoinHandle`]: ../../std/thread/struct.JoinHandle.html | |||
| //! [`thread::current`]: ../../std/thread/fn.current.html | |||
frewsxcv
force-pushed
the
frewsxcv-thread
branch
from
c914b5c to
034dcfd
Compare
frewsxcv
force-pushed
the
frewsxcv-thread
branch
from
034dcfd to
4c08c13
Compare
frewsxcv
dismissed
QuietMisdreavus’s stale review
Comments have been addressed in the latest force push.
|
@bors r+ rollup |
|
📌 Commit 4c08c13 has been approved by |
aidanhs
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 3, 2017
Thread docs fix and improvements. None
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.