Skip to content

feature(compare) Add option to hide raw data, and improve formatting #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

feature(compare) Add option to hide raw data, and improve formatting #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions site/static/compare.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,22 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
</div>
</div>
</fieldset>
<fieldset id="display">
<legend id="display-toggle" class="section-heading">Display<span id="display-toggle-indicator"></span>
</legend>
<div id="display-content" style="display: none;">
<div class="section">
<div class="section-heading"><span>Display raw data</span>
<span class="tooltip">?
<span class="tooltiptext">
Whether to display or not raw data columns.
</span>
</span>
</div>
<input type="checkbox" v-model="showRawData" style="margin-left: 20px;" />
</div>
</div>
</fieldset>
<p v-if="dataLoading && !data">Loading ...</p>
<div v-if="data" id="content" style="margin-top: 15px">
<div id="summary">
Expand Down Expand Up @@ -438,8 +454,8 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
</span>
</span>
</th>
<th>{{before}}</th>
<th>{{after}}</th>
<th v-if="showRawData">{{before}}</th>
<th v-if="showRawData">{{after}}</th>
</tr>
</thead>
<tbody v-if="testCases.length === 0">
Expand All @@ -458,17 +474,16 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
</a>
</td>
<td>
{{ testCase.significanceFactor ? testCase.significanceFactor.toFixed(2) + "x" :"-"
}}
{{ testCase.significanceFactor ? testCase.significanceFactor.toFixed(2) + "x" : "-" }}
</td>
<td>
<td v-if="showRawData">
<a v-bind:href="detailedQueryLink(data.a.commit, testCase)">
{{ testCase.datumA }}
<abbr :title="testCase.datumA">{{ testCase.datumA.toFixed(2) }}</abbr>
</a>
</td>
<td>
<td v-if="showRawData">
<a v-bind:href="detailedQueryLink(data.b.commit, testCase)">
{{ testCase.datumB }}
<abbr :title="testCase.datumB">{{ testCase.datumB.toFixed(2) }}</abbr>
</a>
</td>
</tr>
Expand Down Expand Up @@ -538,6 +553,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
incrPatched: true
}
},
showRawData: false,
data: null,
dataLoading: false
},
Expand Down Expand Up @@ -767,6 +783,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
}
toggleFilters("filters-content", "filters-toggle-indicator");
toggleFilters("search-content", "search-toggle-indicator");
toggleFilters("display-content", "display-toggle-indicator");

function testCaseString(testCase) {
return testCase.benchmark + "-" + testCase.profile + "-" + testCase.scenario;
Expand All @@ -778,6 +795,9 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
document.getElementById("search-toggle").onclick = (e) => {
toggleFilters("search-content", "search-toggle-indicator");
};
document.getElementById("display-toggle").onclick = (e) => {
toggleFilters("display-content", "display-toggle-indicator");
};

function unique(arr) {
return arr.filter((value, idx) => arr.indexOf(value) == idx);
Expand Down