Skip to content

feature(compare) Add option to hide raw data, and improve formatting #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

feature(compare) Add option to hide raw data, and improve formatting #1091

merged 1 commit into from
Nov 4, 2021

Conversation

homersimpsons
Copy link
Contributor

fixes #998

@homersimpsons
Copy link
Contributor Author

image
image

@Mark-Simulacrum
Copy link
Member

It looks like the column headers are pretty poorly aligned - that might be something to tackle in a different PR, since it appears pre-existing, but seems worth fixing. Probably needs to be played with to make it look good.

@Mark-Simulacrum Mark-Simulacrum merged commit 835cb5c into rust-lang:master Nov 4, 2021
@homersimpsons
Copy link
Contributor Author

homersimpsons commented Nov 4, 2021

Yes, the headers are left-aligned while the content are centered in the cell. I'm no expert in UI so I cannot know which content should be aligned to which side ....

@homersimpsons homersimpsons deleted the feature/raw-data-display branch November 4, 2021 18:16
@Mark-Simulacrum
Copy link
Member

I would match the alignment of the values to start.

@Mark-Simulacrum
Copy link
Member

@homersimpsons I think it'd be helpful to move the toggle for displaying raw values into the Filter box -- that takes up less vertical space, and I don't think it's inherently a different "kind" of toggle -- at least not enough to warrant a separate box.

@homersimpsons
Copy link
Contributor Author

I can do that, the idea was that this checkbox do not change the displayed results but only the way they are displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the absolute test result numbers from the comparison page
2 participants