Skip to content

fix(compare) Reduce content top offset: merge display into filter #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix(compare) Reduce content top offset: merge display into filter #1093

merged 1 commit into from
Nov 9, 2021

Conversation

homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Nov 8, 2021 •
edited
Loading

Addresses #1091 (comment)

r? @Mark-Simulacrum

document.getElementById('content').offsetTop; // 404

I also opened #1094 with an alternative solution

@homersimpsons homersimpsons mentioned this pull request Nov 8, 2021
Closed
@Mark-Simulacrum
Copy link
Member

Could you provide screenshots of how this looks (on both variants)?

@homersimpsons
Copy link
Contributor Author

image

I added one to the other PR.

@Mark-Simulacrum
Copy link
Member

Yeah, I think I prefer this one. Thanks!

@Mark-Simulacrum Mark-Simulacrum merged commit a179114 into rust-lang:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@homersimpsons @Mark-Simulacrum