Change wording in perf summary PR comment to expose the used aggregation statistic #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice change, it adds precision. I also wonder if we should give the arithmetic mean of all changes? Averaging the regressions and improvements separately feels a bit strange to me. I.e. add a line "Arithmetic mean of all relevant changes: ..." Or possibly combine the three lines into one, something like: "Arithmetic means of relevant changes: N% (all), P% (improvements), Q% (regressions)"? |
Kobzol
force-pushed
the
summary-wording
branch
from
4fcfc52 to
f4583af
Compare
|
I think that it would be better readable on separate lines. I like the idea with the average of all changes, sometimes on first look it's not apparent what's the overall direction/magnitude of the change. |
nnethercote
reviewed
Feb 24, 2022
nnethercote
reviewed
Feb 24, 2022
nnethercote
reviewed
Feb 24, 2022
nnethercote
reviewed
Feb 24, 2022
Kobzol
force-pushed
the
summary-wording
branch
from
f4583af to
6505005
Compare
Kobzol
force-pushed
the
summary-wording
branch
from
6505005 to
1835101
Compare
nnethercote
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nnethercote mentioned that the wording is quite opaque ("average"), as it didn't mention what kind of average it is. I suggest to change the wording from "average" to "arithmetic mean" (possibly geometric mean in the future if we change the calculation). I used the same wording in the compare site summary tooltip (#1179).