Site: compress responses #1201
Merged
Site: compress responses #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miwig
force-pushed
the
compress-responses
branch
from
3308896 to
012f1a9
Compare
|
I've implemented your suggestions. Let me know if there's more :) |
Mark-Simulacrum
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
It might be worth migrating to plain JSON for all our responses, now that we're compressing them I imagine that might be not that much of a size/performance hit, particularly in browsers where JSON loading is pretty well optimized (compared to the JS library we're using).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1187. I've chosen Brotli as the compression method, which is supported in all major browsers and should be better and faster than gzip.
For now, compression is applied to all POST request responses (including the compare page), and to the graph/graphs requests.
It should be a performance win, especially on slower connections, but it's hard to tell how much without #1194 running in prod. It would also be great to have a recent dump of the database for local testing.