Add brotli compression of static assets #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
requested changes
Mar 16, 2024
There was a problem hiding this comment.
This is a great idea! #1201 enabled compression on-the-fly, but since our webserver is not very powerful, and on-the-fly compression provides much worse results with the current options (the compare.js script still has more than 200 KiB), and we already bake static assets into the binary, this seems like a great way to reduce payload size.
I left some comments about the implementation.
Zentrik
force-pushed
the
brotli
branch
2 times, most recently
from
eaad923 to
50991a4
Compare
200kb reduction in compare.js size from 277kb to 77kb.
Kobzol
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if the rust code isn't idiomatic. This achieves a 200kb reduction in compare.js size from ~292kb to ~77kb.