Comparison page table tweaks and fixes #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Great, looks much better :) The wrong label was my bad from a previous PR, thanks for the fix.
Maybe I would also remove word-wrap: break-word; from the <th> element to avoid this:
But it's not a big deal.
I suppose that we should merge the Vue3 changes asap to avoid hoarding conflicts in the UI.
|
We should likely right-align all numbers instead of centering, as it makes scanning and comparisons between rows harder, especially without thousand-separators. |
|
This is how it would look with right align: It's probably a good idea to do this for the numeric columns indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues in the comparison page:
Before
After