Skip to content

Align numeric columns to right in compare table #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 30, 2022

Continuation of #1254.
image
image

The % Change header looks a bit weird. This is how it looks right aligned:
image

#content td was removed, since it was overwriting specificity of other rules and it was only really used in benches and bootstrap (there is no other <td>).

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make more sense to just right align the raw numbers. The percentage change and significance factor are pretty easy to scan even when centered (and we could conceivably always display them as NN.NN if we wanted them to occupy the same width).

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 30, 2022

I agree that it's most important for the raw numbers. The significance factor isn't that important IMO, but for the % change it's easier for me to judge the size difference if it's aligned to the same edge. But it's a small thing.

@rylev
Copy link
Member

rylev commented Apr 4, 2022

@Kobzol are you planning on changing the alignment of just the raww data or do you still think the right alignment for all of the numeric columns is the right way to go?

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 4, 2022

I still think that right aligning the numeric column with % change would look a bit better, but it would also make the header look silly, and the % change is quite readable as is for the moment. So I'll only modify the raw numbers column in this PR.

@Kobzol Kobzol force-pushed the compare-right-align branch from 27ac4f4 to d0b14ec Compare April 4, 2022 08:11
@rylev rylev merged commit f3fc582 into master Apr 4, 2022
@rylev rylev deleted the compare-right-align branch April 4, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants