Full Range Benchmark Result Chart

[eth3lbert]

Resolves #1835

[Kobzol]

Hi, thanks for the PR! I'm a bit busy at the moment, but I'll try to take a look this week.

[eth3lbert]

no worries! take your time :)

[eth3lbert]

I keep forgetting fmt and check. 😅
Rebased and feedback addressed. Thanks for the review and feedback.

[Kobzol]

Looks good, thank you! Let's see how it works on production data.

[Kobzol]

Ah, looks like the end date should be trimmed in the UI. The server caps it at the commit date, but here it is displayed in the future, which doesn't make sense.

[Kobzol]

While we're at it, the The shaded region shows values that are more recent than the benchmarked commit message should change benchmarked to end.

@eth3lbert Let me know if you wanna fix these things :) If not, I'll take a look at it.

[eth3lbert]

Ah, looks like the end date should be trimmed in the UI. The server caps it at the commit date, but here it is displayed in the future, which doesn't make sense.

To confirm, is the issue related to how the graph title displays the end date? Specifically, you want it to show "today" (or the last date from the response) if it's a future date, is that correct?

[Kobzol]

Yeah, it's just about the UI text. The end date can be in the future w.r.t. the benchmarked commit, that is fine, but it should never be in the actual future, w.r.t. "today" :)

[eth3lbert]

Ok, I will take a look.

[Zentrik]

This is also seemed to break the link to the history graph, start is now a human formatted date which is incorrect, e.g. https://perf.rust-lang.org/index.html?start=Sun%20Feb%2011%202024%2014:01:38%20GMT+0000%20(Greenwich%20Mean%20Time)&end=7de1a1f6db26cf7af43cca74819118428e6317ee&benchmark=exa-0.10.1&profile=opt&scenario=incr-full&stat=instructions:u

To fix just update

rustc-perf/site/frontend/src/pages/compare/compile/table/benchmark-detail.vue

Line 256 in 908eaaf

const start = getPastDate(new Date(commit.date), 30);

to use fomatDate.

[eth3lbert]

This is also seemed to break the link to the history graph, start is now a human formatted date which is incorrect, e.g. https://perf.rust-lang.org/index.html?start=Sun%20Feb%2011%202024%2014:01:38%20GMT+0000%20(Greenwich%20Mean%20Time)&end=7de1a1f6db26cf7af43cca74819118428e6317ee&benchmark=exa-0.10.1&profile=opt&scenario=incr-full&stat=instructions:u

Thanks for letting me know! I'll get it fixed.

[eth3lbert]

@Kobzol I guess this could be resolved at the computing graph range function, right? Or is there any reason to allow the end date to be after the current date?

If we address this in the computing graph range, we might want to reintroduce the previous implementation related to daysInPast 😅

[Kobzol]

I think that the only thing that should be added is make sure that end is earlier_or(end_commit_date + DAYS_RANGE / 2, today). Also, if the end day is today, then start should be set to today - 30 days (unless the start_commit_date is earlier, of course).