Skip to content

Address reported issues for the detail chart #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

eth3lbert
Copy link
Contributor

Fix reported issues #1842 (comment) and #1842 (comment)

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It's surprising how complicated it is to think about all the various situations that can arise in this seemingly simple situation 😅

@Kobzol Kobzol merged commit 84f413d into rust-lang:master Mar 12, 2024
@eth3lbert eth3lbert deleted the chart-range branch March 12, 2024 21:18
@eth3lbert
Copy link
Contributor Author

Ah, I forgot to change the word benchmarked to end 😅

@Kobzol
Copy link
Contributor

Kobzol commented Mar 12, 2024

The original motivation for the benchmarked name was that mostly you look at the page when you open a perf. result from a PR that was benchmarked very recently, so the word makes sense there. Of course, sometimes you also open it later, and then it doesn't make that much sense, since both the start and end commits are "benchmarked", so end probably makes more sense. But it's a very small thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants