Format the if expression at the end of the block in a single line #3338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| let shape = self.shape(); | ||
| let rewrite = self.with_context(|ctx| { | ||
| format_expr(stmt_expr(&stmts[0])?, ExprType::SubExpression, ctx, shape) |
There was a problem hiding this comment.
This is in theory applicable to any expression kind rather than to if only.
Basically, the rule is "print trailing expressions as expressions, rather than statements".
There was a problem hiding this comment.
I'm not sure where else that would make a difference though.
There was a problem hiding this comment.
Thanks, I think that's right. The only thing to take into account is if the last expression is one of continue, return or break, then we need to add a trailing semicolon. I'll see if I can simplify this a bit more.
|
Also, could in the end, this to be squashed on a single commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a successor of #2778. Huge thanks to @csmoe for tackling to this in the first place.
Closes #2777.