Allow primitive types in the code generator and add vdup instructions #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Amanieu
reviewed
Apr 12, 2021
crates/stdarch-gen/neon.spec
Outdated
| n = HFLEN | ||
| validate 0 | ||
|
|
||
| aarch64 = str |
There was a problem hiding this comment.
Rather than using a "fake" instruction like this, could you instead somehow mark this intrinsic as not requiring an instruction test?
There was a problem hiding this comment.
This can cause issues like #1104 (comment) when running the tests in release mode.
There was a problem hiding this comment.
It seems that the result of llvm is different in release mode? I will try to correct the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: