Add vgetq_lane_s32 #903
Merged
Add vgetq_lane_s32 #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
The implementation basically matches the existing vgetq_lane_u32
Amanieu
reviewed
Sep 10, 2020
crates/core_arch/src/arm/neon/mod.rs
Outdated
| #[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(mov, imm5 = 2))] | ||
| pub unsafe fn vgetq_lane_s32(v: int32x4_t, imm5: i32) -> i32 { | ||
| if (imm5) < 0 || (imm5) > 3 { | ||
| unreachable_unchecked() |
There was a problem hiding this comment.
Use a panic here instead. This will be optimized out since imm5 is required to be a constant.
crates/core_arch/src/arm/neon/mod.rs
Outdated
| if (imm5) < 0 || (imm5) > 3 { | ||
| unreachable_unchecked() | ||
| } | ||
| let imm5 = (imm5 & 0b11) as u32; |
There was a problem hiding this comment.
The masking isn't needed since you've already used a range check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation basically matches the existing vgetq_lane_u32