Skip to content

Add vgetq_lane_s32 #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Add vgetq_lane_s32 #903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97f5d5
Add vgetq_lane_s32
jrmuizel Sep 9, 2020
14e2107
Simplify get_lane bounds checks on imm5
jrmuizel Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 28 additions & 23 deletions crates/core_arch/src/arm/neon/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,11 +1315,8 @@ pub unsafe fn vtbx4_p8(a: poly8x8_t, b: poly8x8x4_t, c: uint8x8_t) -> poly8x8_t
// `mov` seems to be an acceptable intrinsic to compile to
// #[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(vmov, imm5 = 1))]
pub unsafe fn vgetq_lane_u64(v: uint64x2_t, imm5: i32) -> u64 {
if (imm5) < 0 || (imm5) > 1 {
unreachable_unchecked()
}
let imm5 = (imm5 & 0b1) as u32;
simd_extract(v, imm5)
assert!(imm5 >= 0 && imm5 <= 1);
simd_extract(v, imm5 as u32)
}

/// Move vector element to general-purpose register
Expand All @@ -1332,9 +1329,7 @@ pub unsafe fn vgetq_lane_u64(v: uint64x2_t, imm5: i32) -> u64 {
// FIXME: no 32bit this seems to be turned into two vmov.32 instructions
// validate correctness
pub unsafe fn vget_lane_u64(v: uint64x1_t, imm5: i32) -> u64 {
if imm5 != 0 {
unreachable_unchecked()
}
assert!(imm5 == 0);
simd_extract(v, 0)
}

Expand All @@ -1346,11 +1341,8 @@ pub unsafe fn vget_lane_u64(v: uint64x1_t, imm5: i32) -> u64 {
#[cfg_attr(all(test, target_arch = "arm"), assert_instr("vmov.u16", imm5 = 2))]
#[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(umov, imm5 = 2))]
pub unsafe fn vgetq_lane_u16(v: uint16x8_t, imm5: i32) -> u16 {
if (imm5) < 0 || (imm5) > 7 {
unreachable_unchecked()
}
let imm5 = (imm5 & 0b111) as u32;
simd_extract(v, imm5)
assert!(imm5 >= 0 && imm5 <= 7);
simd_extract(v, imm5 as u32)
}

/// Move vector element to general-purpose register
Expand All @@ -1361,11 +1353,20 @@ pub unsafe fn vgetq_lane_u16(v: uint16x8_t, imm5: i32) -> u16 {
#[cfg_attr(all(test, target_arch = "arm"), assert_instr("vmov.32", imm5 = 2))]
#[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(mov, imm5 = 2))]
pub unsafe fn vgetq_lane_u32(v: uint32x4_t, imm5: i32) -> u32 {
if (imm5) < 0 || (imm5) > 3 {
unreachable_unchecked()
}
let imm5 = (imm5 & 0b11) as u32;
simd_extract(v, imm5)
assert!(imm5 >= 0 && imm5 <= 3);
simd_extract(v, imm5 as u32)
}

/// Move vector element to general-purpose register
#[inline]
#[target_feature(enable = "neon")]
#[cfg_attr(target_arch = "arm", target_feature(enable = "v7"))]
#[rustc_args_required_const(1)]
#[cfg_attr(all(test, target_arch = "arm"), assert_instr("vmov.32", imm5 = 2))]
#[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(mov, imm5 = 2))]
pub unsafe fn vgetq_lane_s32(v: int32x4_t, imm5: i32) -> i32 {
assert!(imm5 >= 0 && imm5 <= 3);
simd_extract(v, imm5 as u32)
}

/// Move vector element to general-purpose register
Expand All @@ -1376,11 +1377,8 @@ pub unsafe fn vgetq_lane_u32(v: uint32x4_t, imm5: i32) -> u32 {
#[cfg_attr(all(test, target_arch = "arm"), assert_instr("vmov.u8", imm5 = 2))]
#[cfg_attr(all(test, target_arch = "aarch64"), assert_instr(umov, imm5 = 2))]
pub unsafe fn vget_lane_u8(v: uint8x8_t, imm5: i32) -> u8 {
if (imm5) < 0 || (imm5) > 7 {
unreachable_unchecked()
}
let imm5 = (imm5 & 7) as u32;
simd_extract(v, imm5)
assert!(imm5 >= 0 && imm5 <= 7);
simd_extract(v, imm5 as u32)
}

/// Duplicate vector element to vector or scalar
Expand Down Expand Up @@ -1892,6 +1890,13 @@ mod tests {
assert_eq!(r, 2);
}

#[simd_test(enable = "neon")]
unsafe fn test_vgetq_lane_s32() {
let v = i32x4::new(1, 2, 3, 4);
let r = vgetq_lane_s32(transmute(v), 1);
assert_eq!(r, 2);
}

#[simd_test(enable = "neon")]
unsafe fn test_vget_lane_u64() {
let v: u64 = 1;
Expand Down