Skip to content

Localize Privacy Notice #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Localize Privacy Notice #1035

merged 1 commit into from
Mar 13, 2020

Conversation

jrvidal
Copy link
Contributor

@jrvidal jrvidal commented Mar 12, 2020

Fixes #1034

@Manishearth Manishearth merged commit 9ff2eea into rust-lang:master Mar 13, 2020
@Manishearth
Copy link
Member

Thanks! Once this gets deployed to www-staging.rust-lang.org/ I'll have a closer look to see if there are any differences.

@XAMPPRocky
Copy link
Member

@Manishearth Should we have something at the top saying the english version is the canonical version like people have suggested for other policies?

@Manishearth
Copy link
Member

Oh, yes, definitely. Good catch

@Manishearth
Copy link
Member

The content hasn't changed 👍 We're good to go for translating it, though we should still add that header.

@upsuper
Copy link
Contributor

upsuper commented Dec 4, 2020

Hey! I noticed this new string just now (quite long lag...)

Can we avoid putting large chunk of HTML like policies-privacy-page-crates-io-desc into text piece? Pontoon's UI is not particularly optimized for large chunk of text like this. It's hard to translate (you have to translate all in one go or nothing), hard to review (you have to manually scroll original and translation), hard to distribute the work (again, you have to do them altogether), hard to update (you can't reuse anything from previous translation even if only minor changes are done to the text).

It would be appreciated if this kind of text can be broken down to just one item a string instead, e.g. rather than having <dl><dt><dd> all in ftl file, keep the structure in the template, and only have the <p>s level of content in the string.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize privacy policy
4 participants