Skip to content

Deploy #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 30, 2021
Merged

Deploy #1579

merged 34 commits into from
Jul 30, 2021

Conversation

Manishearth
Copy link
Member

No description provided.

dependabot-preview bot and others added 30 commits April 19, 2021 06:23
Bumps [rust_team_data](https://github.com/rust-lang/team) from `756932f` to `b70fce2`.
- [Release notes](https://github.com/rust-lang/team/releases)
- [Commits](rust-lang/team@756932f...b70fce2)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [rust_team_data](https://github.com/rust-lang/team) from `b70fce2` to `c896ead`.
- [Release notes](https://github.com/rust-lang/team/releases)
- [Commits](rust-lang/team@b70fce2...c896ead)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [rust_team_data](https://github.com/rust-lang/team) from `c896ead` to `c7f27e2`.
- [Release notes](https://github.com/rust-lang/team/releases)
- [Commits](rust-lang/team@c896ead...c7f27e2)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Refer to Ferris with any pronouns
This commit does a complete refactoring of how the website handles
redirects, fixing multiple problems with them:

* Redirects didn't handle localizations at all, always redirecting to
  the English website even when the proper localization exists.

* Redirects didn't work for multiple path segments, only supporting a
  single segment instead. For example no redirects on /foo/bar could
  have been created.

* Redirects didn't work if another route processed the URL and returned
  404. For example this prevented a redirect for /policies/privacy as
  request was already processed by /policies/:name.

The main changes in this commit are:

* Redirects are now handled in the 404 handler instead of dedicated
  redirect handlers with a lower priority: this allows redirects to be
  performed even when another handler processes the requests and
  explicitly returns a 404 status code.

* Redirects now support paths with an arbitrary amount of segments.

* Redirects now properly handle localizations: they work inside existing
  locales, they convert pre-2018 locales to current locales and only
  redirect to the English version when a pre-2018 locale does not exist
  anymore on the current codebase.
Refactor redirects to be more consistent
non breaking space before exclamation mark in fr
Fix typos and make statements smoother
@Manishearth Manishearth requested a review from a team as a code owner July 30, 2021 19:05
@Manishearth Manishearth merged commit 4740216 into deploy Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants