Curlify more quote marks #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
suggested changes
Nov 29, 2018
| @@ -74,7 +74,7 @@ | |||
| </header> | |||
| <p>Let’s add a dependency to our application. You can find all sorts of libraries on <a href="https://crates.io" | |||
| target="_blank" rel="noopener">crates.io</a>, the package registry for Rust. In Rust, we often refer to | |||
| packages as "crates".</p> | |||
| packages as “crates.”</p> | |||
There was a problem hiding this comment.
could we put the quote before the . - thanks!
templates/learn/get-started.hbs
Outdated
| @@ -154,8 +154,8 @@ fn main() { | |||
| <div class="highlight"></div> | |||
| </header> | |||
| <p>Ferris (they/them) is the unofficial mascot of the Rust Community. Rust programmers call themselves | |||
| "Rustaceans", which is a play on the word "crustacean", which is set of creatures, one of which is a crab!</p> | |||
| <p>Ferris is a name playing off of the adjective, "ferrous", meaning of or pertaining to iron. Since Rust often | |||
| “Rustaceans,” which is a play on the word “crustacean,” which is set of creatures, one of which is a crab!</p> | |||
There was a problem hiding this comment.
please put the quotes inside the ,s - thanks!
| "Rustaceans", which is a play on the word "crustacean", which is set of creatures, one of which is a crab!</p> | ||
| <p>Ferris is a name playing off of the adjective, "ferrous", meaning of or pertaining to iron. Since Rust often | ||
| “Rustaceans,” which is a play on the word “crustacean,” which is set of creatures, one of which is a crab!</p> | ||
| <p>Ferris is a name playing off of the adjective, “ferrous,” meaning of or pertaining to iron. Since Rust often |
There was a problem hiding this comment.
quote inside comma, please!
| @@ -84,7 +84,7 @@ | |||
| which provides just the Visual C++ build tools. Alternately, you | |||
| can <a href="https://www.visualstudio.com/downloads/" target="_blank" rel="noopener">install</a> | |||
| Visual Studio 2017, Visual Studio 2015, or Visual Studio 2013 and during install select | |||
| the "C++ tools". | |||
| the “C++ tools.” | |||
|
I had the impression that in American English, commas and periods should always be inside the quotation marks (source, section Quotation Marks with Commas and Periods). So I “fixed” those as I changed straight quotes to curly quotes. In fact I found three already existing instances of this, so if the commas/periods are to be left outside the quotes here, they should be moved outside in these three instances:
Incidentally, in PR #435 I also changed the order for one instance in templates/what/embedded/showcase.hbs; I changed:
to:
Question: Which convention should be used? |
|
“Commas and periods inside” is the style for all documentation, at least. I don’t know how the website people feel about it.
… On Nov 30, 2018, at 6:37 AM, Trevor Spiteri ***@***.***> wrote:
I had the impression that in American English, commas and periods should always be inside the quotation marks (source, section Quotation Marks with Commas and Periods). So I “fixed” those as I changed straight quotes to curly quotes.
In fact I found three already existing instances of this, so if the commas/periods are to be left outside the quotes here, they should be moved outside in these three instances:
templates/learn/index.hbs: Affectionately nicknamed “the book,” The Rust...
templates/learn/index.hbs: It’s also sometimes called “the ’nomicon.”
templates/policies/code-of-conduct.hbs: ... the user will be “kicked,” i.e., kicked out...
Incidentally, in PR #435 I also changed the order for one instance in templates/what/embedded/showcase.hbs; I changed:
...with the tag line 'safe, fast, concurrent – pick three'.
to:
... with the tag line ‘safe, fast, concurrent – pick three.’
Question: Which convention should be used?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ok @tspiteri - sorry about the confusion! Let's stick with what you originally had. |
ashleygwilliams
approved these changes
Nov 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curlify some double-quote marks missed in #435.