Skip to content

Curlify more quote marks #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Curlify more quote marks #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a2312
Curlify more quote marks
tspiteri Nov 29, 2018
0bb754a
Merge branch 'master' into quotes
ashleygwilliams Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/learn/get-started.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
</header>
<p>Let’s add a dependency to our application. You can find all sorts of libraries on <a href="https://crates.io"
target="_blank" rel="noopener">crates.io</a>, the package registry for Rust. In Rust, we often refer to
packages as "crates".</p>
packages as “crates.”</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we put the quote before the . - thanks!

<p>In this project, we’ll use a crate called <a href="https://crates.io/crates/ferris-says" target="_blank" rel="noopener"><code>ferris-says</code></a>.
<p>In our <code>Cargo.toml</code> file we’ll add this information (that we got from the crate page):</p>
<p>
Expand Down Expand Up @@ -154,8 +154,8 @@ fn main() {
<div class="highlight"></div>
</header>
<p>Ferris (they/them) is the unofficial mascot of the Rust Community. Rust programmers call themselves
"Rustaceans", which is a play on the word "crustacean", which is a set of creatures, one of which is a crab!</p>
<p>Ferris is a name playing off of the adjective, "ferrous", meaning of or pertaining to iron. Since Rust often
“Rustaceans,” which is a play on the word “crustacean,” which is set a of creatures, one of which is a crab!</p>
<p>Ferris is a name playing off of the adjective, “ferrous,” meaning of or pertaining to iron. Since Rust often
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote inside comma, please!

forms on iron, it seemed like a fun origin for our mascot’s name!</p>
<p>You can find more images of Ferris on <a href="http://rustacean.net/" target="_blank" rel="noopener">http://rustacean.net/</a>.
<img alt="a gif of ferris scurrying side to side" src=/static/images/ferris.gif />
Expand Down
2 changes: 1 addition & 1 deletion templates/tools/install.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
which provides just the Visual C++ build tools. Alternately, you
can <a href="https://www.visualstudio.com/downloads/" target="_blank" rel="noopener">install</a>
Visual Studio 2017, Visual Studio 2015, or Visual Studio 2013 and during install select
the "C++ tools".
the “C++ tools.”
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

</p>
<p>
For further information about configuring Rust on Windows see the
Expand Down
2 changes: 1 addition & 1 deletion templates/what/cli/maintainable.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
content of that one environment variable is empty? These
cases are easy to forget about! But thanks to its approach
to error handling and its library design, Rust will point
out these "what if" situations before you even run your
out these “what if” situations before you even run your
program.
</p>
<a href="https://doc.rust-lang.org/book/2018-edition/ch09-00-error-handling.html" target="_blank" rel="noopener" class="button button-secondary">
Expand Down