Skip to content

Move templates closer to what handlebars-fluent uses #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

Manishearth
Copy link
Member

This bring us closer to #946

r? @XAMPPRocky or @skade

Fixes #957

@Manishearth
Copy link
Member Author

After this I think the only work that needs to be done is the actual integration work, the templates are now using the correct format so there won't be much churn.

@Manishearth
Copy link
Member Author

I have verified that stuff is still working after this.

@XAMPPRocky
Copy link
Member

@Manishearth This looks good to me! The one question I have is that you also changed all of the arguments from being like fluent community-team to fluent "community-team" is this actually important to the code working or is it a style choice?

@Manishearth
Copy link
Member Author

Yes, it's important to the code working. See alerque/handlebars-helper-fluent#2 , what we used to do was incorrect. This was mentioned in the second line of #957

To be able to switch over to handlebars-fluent we need to make this change as well, the old syntax will not work anymore.

@Manishearth Manishearth merged commit 03c6daa into rust-lang:master Dec 6, 2019
@Manishearth Manishearth deleted the rename-templates branch December 6, 2019 23:47
@Manishearth Manishearth restored the rename-templates branch December 6, 2019 23:47
@Manishearth Manishearth deleted the rename-templates branch December 6, 2019 23:47
@XAMPPRocky
Copy link
Member

That's fine, I have no preference I just wanted to know for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace {{text}} with {{fluent}}
2 participants