-
Notifications
You must be signed in to change notification settings - Fork 434
[Tooltip] Screen reader issues with hover and on focus content #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cus content, Superbadges & Super Sets - View Superbadge, Prerequisite - handleKeyDown method added
…cus content, Superbadges & Super Sets - View Superbadge, Prerequisite - snapshots and component-docs updated
…cus content - aria-label removed
…cus content - isHoveringTooltip variable added: check if user is hovering on tooltip and prevent hiding it - onMouseLeave method added to close tooltip after hovering
…cus content - docs and snapshots updated
…cus content - stopPropagation on mouse leave event added
…cus content - suggestions applied
@interactivellama can we get approval on this PR please? Thank you. |
@mlopez-sf With this fix, you need to be very careful when moving the pointer from the trigger to the tooltip content, otherwise the tooltip will disappear. I am wondering if it is better to add a prop like https://design-system-react-site.herokuapp.com/components/popovers/#prop-hasNoCloseButton, so that user can close the tooltip with a close button or using escape keep |
I agree that mouse hovering on small tooltips is difficult. However, before this fix, WCAG 2.1 SC 1.4.13 Content on Hover or Focus was not passing. @mlopez-sf Thank you for the contribution. |
Congrats on merging your first pull request to Design System React! 🎉 |
@mlopez-sf I'll try to get you a release tomorrow. |
@mlopez-sf It's looking more like Thursday now. |
Original Ticket:
W-14619658
Related Issue:
3174
Fixes
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.