Skip to content

[Tooltip] Screen reader issues with hover and on focus content #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 5, 2025
Merged

[Tooltip] Screen reader issues with hover and on focus content #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bfd1412
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 24, 2025
469c9bc
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 24, 2025
5bcb1fd
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 27, 2025
c58b0cd
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 27, 2025
cf62615
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 27, 2025
51cd0d8
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 28, 2025
4e07164
@W-14619658 [Accessibility] Screen reader issues with hover and on fo…
mlopez-sf Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/builder-header/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ exports[`DOM snapshots SLDSBuilderHeader After Successful Save 1`] = `
className="slds-color__text_gray-10 slds-align-middle slds-m-right_small"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
tabIndex={0}
Expand Down Expand Up @@ -961,6 +962,7 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
style={
Expand Down Expand Up @@ -1042,6 +1044,7 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
style={
Expand Down Expand Up @@ -2595,6 +2598,7 @@ exports[`DOM snapshots SLDSBuilderHeader Failed Save 1`] = `
className="slds-button slds-color__text_gray-10 slds-align-middle slds-m-right_x-small"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down
5 changes: 5 additions & 0 deletions components/combobox/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,7 @@ exports[`DOM snapshots SLDSCombobox Base Inline Help 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1688,6 +1689,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
onBlur={[Function]}
onClick={null}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="option"
Expand Down Expand Up @@ -1744,6 +1746,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-4"
onKeyDown={[Function]}
onMouseLeave={[Function]}
role="tooltip"
style={
Object {
Expand Down Expand Up @@ -1835,6 +1838,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
onBlur={[Function]}
onClick={null}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="option"
Expand Down Expand Up @@ -1891,6 +1895,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-6"
onKeyDown={[Function]}
onMouseLeave={[Function]}
role="tooltip"
style={
Object {
Expand Down
19 changes: 18 additions & 1 deletion components/component-docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17575,7 +17575,24 @@
"name": "handleMouseLeave",
"docblock": null,
"modifiers": [],
"params": [],
"params": [
{
"name": "e",
"type": null
}
],
"returns": null
},
{
"name": "handleKeyDown",
"docblock": null,
"modifiers": [],
"params": [
{
"name": "e",
"type": null
}
],
"returns": null
},
{
Expand Down
3 changes: 3 additions & 0 deletions components/input/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,7 @@ exports[`DOM snapshots SLDSInput Field Level Help 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1695,6 +1696,7 @@ exports[`DOM snapshots SLDSInput Field Level Help, Tooltip Open 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand All @@ -1717,6 +1719,7 @@ exports[`DOM snapshots SLDSInput Field Level Help, Tooltip Open 1`] = `
className="absolute-positioned slds-nubbin_bottom-left slds-popover slds-popover_tooltip"
id="field-level-help-tooltip"
onKeyDown={[Function]}
onMouseLeave={[Function]}
role="tooltip"
style={
Object {
Expand Down
4 changes: 4 additions & 0 deletions components/menu-dropdown/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5375,6 +5375,7 @@ exports[`DOM snapshots SLDSMenuDropdown With tooltips (open) 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="menuitem"
Expand All @@ -5391,6 +5392,7 @@ exports[`DOM snapshots SLDSMenuDropdown With tooltips (open) 1`] = `
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="dropdown-with-tooltips-item-2-tooltip"
onKeyDown={[Function]}
onMouseLeave={[Function]}
role="tooltip"
style={
Object {
Expand Down Expand Up @@ -5459,6 +5461,7 @@ exports[`DOM snapshots SLDSMenuDropdown With tooltips (open) 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="menuitem"
Expand All @@ -5475,6 +5478,7 @@ exports[`DOM snapshots SLDSMenuDropdown With tooltips (open) 1`] = `
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="dropdown-with-tooltips-item-5-tooltip"
onKeyDown={[Function]}
onMouseLeave={[Function]}
role="tooltip"
style={
Object {
Expand Down
1 change: 1 addition & 0 deletions components/page-header/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,7 @@ exports[`DOM snapshots SLDSPageHeader Record Home (truncates) 1`] = `
className="slds-truncate"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
tabIndex="0"
Expand Down
29 changes: 29 additions & 0 deletions components/progress-indicator/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -68,6 +69,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -100,6 +102,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -140,6 +143,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -178,6 +182,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -263,6 +268,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Disabled Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -302,6 +308,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Disabled Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -343,6 +350,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Disabled Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -377,6 +385,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Disabled Steps 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -415,6 +424,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Disabled Steps 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -500,6 +510,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -541,6 +552,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -582,6 +594,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -623,6 +636,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -664,6 +678,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -697,6 +712,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -730,6 +746,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -763,6 +780,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -796,6 +814,7 @@ exports[`DOM snapshots SLDSProgressIndicator Base With Many Steps 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -875,6 +894,7 @@ exports[`DOM snapshots SLDSProgressIndicator Completed Progress 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -914,6 +934,7 @@ exports[`DOM snapshots SLDSProgressIndicator Completed Progress 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -955,6 +976,7 @@ exports[`DOM snapshots SLDSProgressIndicator Completed Progress 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -998,6 +1020,7 @@ exports[`DOM snapshots SLDSProgressIndicator Completed Progress 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1031,6 +1054,7 @@ exports[`DOM snapshots SLDSProgressIndicator Completed Progress 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1405,6 +1429,7 @@ exports[`DOM snapshots SLDSProgressIndicator Step Error 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1444,6 +1469,7 @@ exports[`DOM snapshots SLDSProgressIndicator Step Error 1`] = `
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
Expand Down Expand Up @@ -1484,6 +1510,7 @@ exports[`DOM snapshots SLDSProgressIndicator Step Error 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -1524,6 +1551,7 @@ exports[`DOM snapshots SLDSProgressIndicator Step Error 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down Expand Up @@ -1562,6 +1590,7 @@ exports[`DOM snapshots SLDSProgressIndicator Step Error 1`] = `
className="slds-button slds-progress__marker slds-is-disabled"
onBlur={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="button"
Expand Down
Loading