Update GettingStartedWithFPSection.scala

[slashdev1]

I think function isSorted has a mistake because isSorted(Array(1, 3, 5, 7), (x: Int, y: Int) => x > y) should be return false:
in the first step condition 1 > 3 is false

[FRosner]

Hi! Thanks for the contribution. It is confusing to me indeed why the higher order function, which is the sorted condition, is negated in the current implementation. If you are modifying the logic however you either need to invert all the conditions in the exercises or change the expected values in https://github.com/scala-exercises/exercises-fpinscala/blob/master/src/test/scala/fpinscalalib/GettingStartedWithFPSpec.scala#L24

[slashdev1]

Hi. Thanks for the answer. How do you mean it is good idea if I'll change conditions signs in method isSortedAssert below isSorted: > to < and < to >

[FRosner]

I think that makes sense but maybe I'm not getting what the method is supposed to do. Can you find out the original author and ping them here?

[slashdev1]

Hello @jdesiloniz Can you read my previous post and answer it.

[jdesiloniz]

@slashdev1 @FRosner Hello, and thanks for this PR! I think I added that negation by mistake while writing that exercise. I'd move forward with your PR if no one has any objections! 👍

[FRosner]

We should fix the test I guess? We can't just change the code without changing the test, or?

[jdesiloniz]

@FRosner Yeah, fixed this in the following PR: #46. Unfortunately the issues that we had with Travis and the JDK masked the test issue.

[vgrigoriu]

I think the original implementation is correct. If as(n) and as(n + 1) are not ordered, then the whole sequence is not ordered. I think isOrdered(Array(1, 2, 3), (x: Int, y: Int) => x <= y) should be true and isOrdered(Array(1, 2, 3), (x: Int, y: Int) => x > y) should be false.