Skip to content

Fixing exercise after previous merge #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2019
Merged

Fixing exercise after previous merge #46

merged 4 commits into from
Jun 25, 2019

Conversation

jdesiloniz
Copy link

No description provided.

Javier de Siloniz Sandino added 2 commits June 24, 2019 05:59
@jdesiloniz jdesiloniz self-assigned this Jun 24, 2019
Javier de Siloniz Sandino added 2 commits June 24, 2019 06:47
@jdesiloniz jdesiloniz mentioned this pull request Jun 25, 2019
Merged
juanpedromoreno
juanpedromoreno approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, did we change the test in a previous PR?

@FRosner
Copy link
Member

FRosner commented Jun 25, 2019

#43 (comment)

@jdesiloniz jdesiloniz merged commit 491ce39 into master Jun 25, 2019
@jdesiloniz jdesiloniz deleted the bugfix/jsandino/broken-test branch June 25, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees

@jdesiloniz jdesiloniz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdesiloniz @FRosner @juanpedromoreno