Skip to content

Make -Ylog:X log only phase X #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

smarter
Copy link
Member

@smarter smarter commented Dec 12, 2014

There is no need to log the phase after X anymore, containsPhase does
the correct thing.

Review by @odersky

There is no need to log the phase after X anymore, containsPhase does
the correct thing.
@odersky
Copy link
Contributor

odersky commented Dec 13, 2014

That was not the reason for the code. The reason was that most of the time the transformer of a phase runs in the next phase. Compensating that in the logging command is tricky - we'd need to know what is the next phase, which is not always clear.

@smarter
Copy link
Member Author

smarter commented Dec 13, 2014

OK, do you think it'd be useful to have an option to explicitly log only the specified phase? Currently -Ylog:frontend generates a lot of output because of how often firstTransform is run.

@odersky
Copy link
Contributor

odersky commented Dec 13, 2014

Yes, I think this calls for a more nuanced command line syntax.

-Ylog:phaseX+

for logging at phase after phaseX, maybe?

  • Martin

On Sat, Dec 13, 2014 at 6:09 PM, Guillaume Martres <[email protected]

wrote:

OK, do you think it'd be useful to have an option to explicitly log only
the specified phase? Currently -Ylog:frontend generates a lot of output
because of how often firstTransform is run.


Reply to this email directly or view it on GitHub
#273 (comment).

Martin Odersky
EPFL

@smarter
Copy link
Member Author

smarter commented Dec 13, 2014

This could be generalized to -Ylog:phaseX+N to log N phases after phase X, would that be useful?

@odersky
Copy link
Contributor

odersky commented Dec 13, 2014

What would be a use case for this? If there's no convincing one, I would
say let's keep it simple.

  • Martin

On Sat, Dec 13, 2014 at 8:01 PM, Guillaume Martres <[email protected]

wrote:

This could be generalized to -Ylog:phaseX+N to log N phases after phase
X, would that be useful?


Reply to this email directly or view it on GitHub
#273 (comment).

Martin Odersky
EPFL

@smarter
Copy link
Member Author

smarter commented Dec 13, 2014

I don't see one, so I'll try to implement your original proposal.

@odersky
Copy link
Contributor

odersky commented Dec 13, 2014

OK, thanks!

On Sat, Dec 13, 2014 at 9:24 PM, Guillaume Martres <[email protected]

wrote:

I don't see one, so I'll try to implement your original proposal.


Reply to this email directly or view it on GitHub
#273 (comment).

Martin Odersky
EPFL

@smarter
Copy link
Member Author

smarter commented Dec 18, 2014

Superseded by #308 .

@smarter smarter closed this Dec 18, 2014
tgodzik added a commit to tgodzik/scala3 that referenced this pull request Apr 29, 2025
Backport "Handle Typeable" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants