-Ylog:X now only log phase X, use -Ylog:X+ to also log phase X+1 #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| implicit class PhaseListDecorator(val names: List[String]) extends AnyVal { | ||
| def containsPhase(phase: Phase): Boolean = phase match { | ||
| case phase: TreeTransformer => phase.transformations.exists(trans => containsPhase(trans.phase)) | ||
| case _ => names exists (n => n == "all" || phase.phaseName.startsWith(n)) |
There was a problem hiding this comment.
I believe the logic can be simplified and made clearer as follows:
case _ =>
names exists { n =>
n == "all" || {
val strippedName = name.stripSuffix("+")
val indicatedPhase = if (name == strippedName) phase else phase.prev
indicatedPhase.phaseName.startsWith(strippedName)
}
}
There was a problem hiding this comment.
No, that doesn't work, if we have a "+" we want to match on both phase and phase.prev, we could use a list but that seems overkill, what do you think of:
case _ =>
names exists { n =>
n == "all" || {
val strippedName = name.stripSuffix("+")
val logNextPhase = name ne strippedName
phase.phaseName.startsWith(strippedName) ||
(logNextPhase && phase.prev.phaseName.startsWith(strippedName))
}
}There was a problem hiding this comment.
Ah I thought of a different spec. But yours makes more sense, I think. The change looks good.
|
Otherwise LGTM |
smarter
force-pushed
the
change/Ylog-2
branch
from
839c8e0 to
7bef54d
Compare
|
Should be good to be merged now. |
odersky
added a commit
that referenced
this pull request
Dec 18, 2014
-Ylog:X now only log phase X, use -Ylog:X+ to also log phase X+1
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Restore resolving prefixes of implicit Ident" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #273.
Review by @odersky .