new line after rule heading #4174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list is broken on http://dotty.epfl.ch/docs. I suppose it requires a new line after the rule heading (at least the list in workflow.md has a new line and this one is displayed correctly)
dottybot
reviewed
Mar 24, 2018
docs/docs/reference/erased-terms.md
Outdated
| @@ -164,11 +165,15 @@ def h(x: erased Int => Int) = ... | |||
| class K(erased x: Int) { ... } | |||
| ``` | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Is the extra line before also required (here and below)? I thought not.
There was a problem hiding this comment.
Nope, its not but I figured it reads better in the raw version . The fix @allanrenucci provides reads even better IMO, yet I don't know if it is going to fix the initial problem.
|
Merging! Thanks @robstoll 🎉 |
robstoll
added a commit
to robstoll/dotty
that referenced
this pull request
Mar 25, 2018
Seems like the last commit scala#4174 fixed the bullet points but messed up the numbered list. Since I have no preview on how it will look like at http://dotty.epfl.ch/docs/ it's again a guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list is broken on http://dotty.epfl.ch/docs. I suppose it requires a new line after the rule heading (at least the list in workflow.md has a new line and this one is displayed correctly)