-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix indent so numbered list is continuous #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like the last commit scala#4174 fixed the bullet points but messed up the numbered list. Since I have no preview on how it will look like at http://dotty.epfl.ch/docs/ it's again a guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems like the correct fix!
docs/docs/reference/erased-terms.md
Outdated
|
||
|
||
4. Eta expansion | ||
|
||
if `def f(erased x: T): U` then `f: (erased T) => U`. | ||
if `def f(erased x: T): U` then `f: (erased T) => U`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be rendered on the same line as the previous line. So we might as well rewrite it as:
4. Eta expansion: if `def f(erased x: T): U` then `f: (erased T) => U`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not my intention, I'll revert this particular change
docs/docs/reference/erased-terms.md
Outdated
@@ -193,8 +192,7 @@ if `def f(erased x: T): U` then `f: (erased T) => U`. | |||
|
|||
|
|||
6. Overloading | |||
|
|||
Method with `erased` parameters will follow the normal overloading constraints after erasure. | |||
Method with `erased` parameters will follow the normal overloading constraints after erasure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also put it on the previous line:
6. Overloading: methods with `erased` parameters will follow the normal overloading constraints after erasure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Seems like the last commit #4174 fixed the bullet points but messed up the numbered list. Since I have no preview on how it will look like at http://dotty.epfl.ch/docs/ it's again a guess.