Skip to content

fix indent so numbered list is continuous #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2018
Merged

Conversation

robstoll
Copy link
Contributor

Seems like the last commit #4174 fixed the bullet points but messed up the numbered list. Since I have no preview on how it will look like at http://dotty.epfl.ch/docs/ it's again a guess.

Seems like the last commit scala#4174 fixed the bullet points but messed up the numbered list. Since I have no preview on how it will look like at  http://dotty.epfl.ch/docs/ it's again a guess.
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@smarter
Copy link
Member

smarter commented Mar 25, 2018

Since I have no preview on how it will look like at http://dotty.epfl.ch/docs/ it's again a guess.

run sbt genDocs in the project, output in docs/_site/index.html

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems like the correct fix!



4. Eta expansion

if `def f(erased x: T): U` then `f: (erased T) => U`.
if `def f(erased x: T): U` then `f: (erased T) => U`.
Copy link
Contributor

@allanrenucci allanrenucci Mar 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be rendered on the same line as the previous line. So we might as well rewrite it as:

4. Eta expansion: if `def f(erased x: T): U` then `f: (erased T) => U`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not my intention, I'll revert this particular change

@@ -193,8 +192,7 @@ if `def f(erased x: T): U` then `f: (erased T) => U`.


6. Overloading

Method with `erased` parameters will follow the normal overloading constraints after erasure.
Method with `erased` parameters will follow the normal overloading constraints after erasure.
Copy link
Contributor

@allanrenucci allanrenucci Mar 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also put it on the previous line:

6. Overloading: methods with `erased` parameters will follow the normal overloading constraints after erasure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@allanrenucci allanrenucci merged commit c5e40dc into scala:master Mar 25, 2018
@robstoll robstoll deleted the patch-3 branch February 27, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants