-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix indent so numbered list is continuous #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,17 +152,17 @@ Rules | |
* In a method definition | ||
* In a `val` definition (but not `lazy val` or `var`) | ||
|
||
```scala | ||
erased val x = ... | ||
erased def f = ... | ||
```scala | ||
erased val x = ... | ||
erased def f = ... | ||
|
||
def g(erased x: Int) = ... | ||
def g(erased x: Int) = ... | ||
|
||
(erased x: Int) => ... | ||
def h(x: erased Int => Int) = ... | ||
(erased x: Int) => ... | ||
def h(x: erased Int => Int) = ... | ||
|
||
class K(erased x: Int) { ... } | ||
``` | ||
class K(erased x: Int) { ... } | ||
``` | ||
|
||
|
||
2. A reference to an `erased` definition can only be used | ||
|
@@ -177,12 +177,11 @@ class K(erased x: Int) { ... } | |
* `(implicit erased T1, T2) => R <:< (erased T1, T2) => R` | ||
* ... | ||
|
||
Note that there is no subtype relation between `erased T => R` and `T => R` (or `implicit erased T => R` and `implicit T => R`) | ||
Note that there is no subtype relation between `erased T => R` and `T => R` (or `implicit erased T => R` and `implicit T => R`) | ||
|
||
|
||
4. Eta expansion | ||
|
||
if `def f(erased x: T): U` then `f: (erased T) => U`. | ||
if `def f(erased x: T): U` then `f: (erased T) => U`. | ||
|
||
|
||
5. Erasure Semantics | ||
|
@@ -193,8 +192,7 @@ if `def f(erased x: T): U` then `f: (erased T) => U`. | |
|
||
|
||
6. Overloading | ||
|
||
Method with `erased` parameters will follow the normal overloading constraints after erasure. | ||
Method with `erased` parameters will follow the normal overloading constraints after erasure. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would also put it on the previous line:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
|
||
|
||
7. Overriding | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be rendered on the same line as the previous line. So we might as well rewrite it as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not my intention, I'll revert this particular change