Configure IDE with sbt server #5160

Duhemm · 2018-09-25T08:45:09Z

When there's no sbt project, offer to create a new sbt project:
- build.sbt
- project/build.properties
- project/plugins.sbt
Try to connect to a running sbt server instance or start a new server.
- If vscode cannot connect to sbt, ask the user to try again.
Run configureIDE using sbt/exec
- Report error when it fails, asking the user to try again
Periodically check that sbt is still alive; start a new instance otherwise.

smarter · 2018-09-25T20:13:57Z

vscode-dotty/src/extension.ts

+const sbtCheckIntervalMs = 10 * 1000
+
+/** A command that we use to check that sbt is still alive. */
+export const nopCommand = "nop"


I'm not sure this is the way to do things:

If the connection with sbt is closed, we don't need this since we can have a callback on connection.onClose

If sbt blocks while running something, then we will never get a response since there's no timeout for a response

We can't add a timeout for the response, because an sbt command can take an arbitrarily long time to finish (e.g. running tests) and sbt cannot execute more than one command at once.

I think a real solution will require changes to sbt, but I don't know what exactly.

Duhemm · 2018-10-01T13:06:03Z

Remove nop. It's now relying on connection.close to reconnect.

This commis adds a status bar that shows the status of sbt server, and a timer that periodically checks that sbt server is still alive, starting a new instance if necessary.

We use `connection.onClose` to automatically reconnect when the connection with sbt is closed.

Duhemm · 2018-10-10T09:05:02Z

@smarter Everything seems to work on Windows now!

smarter · 2018-10-10T17:42:17Z

vscode-dotty/package.json

@@ -71,7 +71,7 @@
    "scala-lang.scala"
  ],
  "dependencies": {
-    "child-process-promise": "^2.2.1",


If we remove this then https://github.com/lampepfl/dotty/blob/786788b97800dd70841472e999c5f4a286426486/vscode-dotty/src/types.d.ts should be removed or updated too.

smarter · 2018-10-10T17:42:40Z

vscode-dotty/src/extension.ts

@@ -3,7 +3,7 @@
 import * as fs from 'fs';
 import * as path from 'path';

-import * as cpp from 'child-process-promise';
+import * as cpp from 'promisify-child-process';


should be pcp instead of cpp, or childProcess if we want to be explicit.

smarter · 2018-10-10T17:44:51Z

vscode-dotty/src/extension.ts

+const sbtBuildSbtFile = path.join(workspaceRoot, "build.sbt")
+const languageServerArtifactFile = path.join(workspaceRoot, ".dotty-ide-artifact")
+
+function isUnconfiguredProject() {


maybe call this isConfiguredProject to avoid too many negations ?

smarter · 2018-10-17T12:19:15Z

vscode-dotty/src/extension.ts

        }
      })
    }
+
+    configuredProject
+      .then(_ => connectToSbt(coursierPath))


Since starting sbt and running configureIDE might be very slow, I suggest we do not do it if the project has already been configured once (i.e., .dotty-ide-artifact, .dotty-ide.json are present). In the future, the Dotty Language Server will decide itself if it should query the build tool for configuration options.

Duhemm · 2018-10-17T13:09:57Z

@smarter I removed some of the stuff that dealt with sbt server (but we're still using it).
d27f5a4 is the commit to revert if/when we decide to revive that.

Duhemm · 2018-10-17T13:37:37Z

Why {} instead of void ?

Right, I changed it.

If disableDottyIDEFile then the project is not configured, but we should not try to configure it either and just quit the extension, the logic to do this seems to have been lost.

Argh, thanks, I fixed it too.

smarter · 2018-10-17T13:40:27Z

vscode-dotty/src/extension.ts

@@ -83,7 +82,7 @@ export function activate(context: ExtensionContext) {

  } else {
    let configuredProject: Thenable<void> = Promise.resolve()
-    if (isUnconfiguredProject()) {
+    if (!isConfiguredProject()) {
      configuredProject = vscode.window.showInformationMessage(
        "This looks like an unconfigured Scala project. Would you like to start the Dotty IDE?",


Looks like this message is still going to be shown if disableDottyIDEFile is present

🤦‍♂️

This commit changes the behavior of the IDE so that it runs `configureIDE` only if the project hasn't been configured yet. sbt will now be started only if necessary, and the server will not be kept alive longer than necessary.

Duhemm added the area:ide label Sep 25, 2018

allanrenucci assigned smarter Sep 25, 2018

allanrenucci requested a review from smarter September 25, 2018 16:41

smarter reviewed Sep 25, 2018

View reviewed changes

Duhemm force-pushed the wip/vscode-create-config branch from 3f453b4 to 1601cda Compare October 1, 2018 12:50

Duhemm added 6 commits October 10, 2018 08:14

IDE: Initialize sbt project when there's none

5c34a3a

Run configureIDE with sbt server

4789db0

Check sbt is alive and restart it if necessary

6c96109

This commis adds a status bar that shows the status of sbt server, and a timer that periodically checks that sbt server is still alive, starting a new instance if necessary.

Don't pass output channel everywhere

04a9d56

Remove unused parameter

501fbef

Remove nop command

c1f0e75

We use `connection.onClose` to automatically reconnect when the connection with sbt is closed.

Duhemm force-pushed the wip/vscode-create-config branch from 1601cda to c1f0e75 Compare October 10, 2018 06:32

Duhemm added 2 commits October 10, 2018 09:28

IDE: Set working directory when starting sbt

786788b

IDE: Don't rely on current working directory

cf2c367

smarter approved these changes Oct 17, 2018

View reviewed changes

Duhemm force-pushed the wip/vscode-create-config branch 2 times, most recently from b7aa9fd to d57c16a Compare October 17, 2018 13:35

smarter reviewed Oct 17, 2018

View reviewed changes

Duhemm added 2 commits October 17, 2018 16:01

Address review

db52072

Start sbt only if necessary, don't keep server alive

d27f5a4

This commit changes the behavior of the IDE so that it runs `configureIDE` only if the project hasn't been configured yet. sbt will now be started only if necessary, and the server will not be kept alive longer than necessary.

Duhemm force-pushed the wip/vscode-create-config branch from d57c16a to d27f5a4 Compare October 17, 2018 14:03

smarter merged commit c63cbd5 into scala:master Oct 17, 2018

allanrenucci deleted the wip/vscode-create-config branch October 17, 2018 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Configure IDE with sbt server #5160

Configure IDE with sbt server #5160

Uh oh!

Duhemm commented Sep 25, 2018

Uh oh!

smarter Sep 25, 2018

Uh oh!

Duhemm commented Oct 1, 2018

Uh oh!

Duhemm commented Oct 10, 2018

Uh oh!

smarter Oct 10, 2018

Uh oh!

smarter Oct 10, 2018

Uh oh!

smarter Oct 10, 2018

Uh oh!

smarter Oct 17, 2018

Uh oh!

Duhemm commented Oct 17, 2018 •

edited

Loading

Uh oh!

Duhemm commented Oct 17, 2018

Uh oh!

smarter Oct 17, 2018

Uh oh!

Duhemm Oct 17, 2018

Uh oh!

Uh oh!

Configure IDE with sbt server #5160

Configure IDE with sbt server #5160

Uh oh!

Conversation

Duhemm commented Sep 25, 2018

Uh oh!

smarter Sep 25, 2018

Choose a reason for hiding this comment

Uh oh!

Duhemm commented Oct 1, 2018

Uh oh!

Duhemm commented Oct 10, 2018

Uh oh!

smarter Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

smarter Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

smarter Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

smarter Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

Duhemm commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Duhemm commented Oct 17, 2018

Uh oh!

smarter Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

Duhemm Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Duhemm commented Oct 17, 2018 •

edited

Loading