Skip to content

Configure IDE with sbt server #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 17, 2018
Merged

Configure IDE with sbt server #5160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5c34a3a
IDE: Initialize sbt project when there's none
Duhemm Sep 18, 2018
4789db0
Run `configureIDE` with sbt server
Duhemm Sep 21, 2018
6c96109
Check sbt is alive and restart it if necessary
Duhemm Sep 24, 2018
04a9d56
Don't pass output channel everywhere
Duhemm Sep 25, 2018
501fbef
Remove unused parameter
Duhemm Sep 25, 2018
c1f0e75
Remove nop command
Duhemm Oct 1, 2018
786788b
IDE: Set working directory when starting sbt
Duhemm Oct 10, 2018
cf2c367
IDE: Don't rely on current working directory
Duhemm Oct 10, 2018
db52072
Address review
Duhemm Oct 17, 2018
d27f5a4
Start sbt only if necessary, don't keep server alive
Duhemm Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,11 +985,12 @@ object Build {
includeFilter in unmanagedSources := NothingFilter | "*.ts" | "**.json",
watchSources in Global ++= (unmanagedSources in Compile).value,
resourceGenerators in Compile += Def.task {
val defaultIDEConfig = baseDirectory.value / "out" / "default-dotty-ide-config"
IO.write(defaultIDEConfig, dottyVersion)
// Resources that will be copied when bootstrapping a new project
val buildSbtFile = baseDirectory.value / "out" / "build.sbt"
IO.write(buildSbtFile, s"""scalaVersion := "$dottyVersion"""")
val dottyPluginSbtFile = baseDirectory.value / "out" / "dotty-plugin.sbt"
IO.write(dottyPluginSbtFile, s"""addSbtPlugin("$dottyOrganization" % "$sbtDottyName" % "$sbtDottyVersion")""")
Seq(defaultIDEConfig, dottyPluginSbtFile)
Seq(buildSbtFile, dottyPluginSbtFile)
},
compile in Compile := Def.task {
val workingDir = baseDirectory.value
Expand Down
74 changes: 14 additions & 60 deletions vscode-dotty/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions vscode-dotty/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,11 @@
"scala-lang.scala"
],
"dependencies": {
"child-process-promise": "^2.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this then https://github.com/lampepfl/dotty/blob/786788b97800dd70841472e999c5f4a286426486/vscode-dotty/src/types.d.ts should be removed or updated too.

"promisify-child-process": "^2.1.2",
"compare-versions": "^3.4.0",
"vscode-languageclient": "^5.1.0",
"vscode-languageserver": "^5.1.0"
"vscode-languageserver": "^5.1.0",
"vscode-jsonrpc": "4.0.0"
},
"devDependencies": {
"@types/compare-versions": "^3.0.0",
Expand Down
Loading