Partial fixes mypy #224
Merged
Partial fixes mypy #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melonora
added a commit
that referenced
this pull request
Mar 19, 2024
* allow for plotting using specific table (#217) * allow for plotting using specific table * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Change into get with default return * fix issues with pp * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ensure instance key coercable to int dtype * add table keys import * allow feature branches tests * remove table key getters * extract into function * add docstring * don't create unnecessary anndata * allow for label color without specified table * refactor show param validations * refactor show param validations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * big refactor * remove unused render_params.layer * remove redundant code * refactor to mapping * allow later creation of mapping * reimplement color label * fix unused arguments * change points shapes logic * unfixed full implementation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * fix tests * remove duplicate checks * implement nested list groups palette * fix tests * fix or mistake * add dummy test * Change to warning * partial fix mypy * add function type hints --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * silence table deprecation warning * fix tests * silence deprecations and other warnings * Fix incorrect conditional * refactor wanted_elements * remove unwanted extend * further refactor * using getattr * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change palette * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove color if no table * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed! (#222) * fixed! * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Partial fixes mypy (#224) * fix mypy * shut more mypy up * some mypy --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: LucaMarconato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed some mypy fixes