String column names in [0, 1] are now no longer interpreted as colors #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtreis
changed the title
…they-are-not-displayed-by-plrender_shapes-method
timtreis
deleted the
bzugfix/327-if-an-obs-column-name-is-0-or-1-they-are-not-displayed-by-plrender_shapes-method
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 79.27% 79.26% -0.01%
==========================================
Files 11 11
Lines 1785 1799 +14
==========================================
+ Hits 1415 1426 +11
- Misses 370 373 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib considers values like "0", "0.3" or "1.0" as valid grey-scale colors. Therefore,
colors.is_color_like("0")returnsTrue. This was causing an issue (see linked) for at least one user. This PR introduces a change so that these strings are no longer interpreted as colors.(The failing tests are fixed in #323)