Categorical data is now correctly colored in the legend when plotting v2 #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 80.34% 79.27% -1.08%
==========================================
Files 11 11
Lines 1745 1785 +40
==========================================
+ Hits 1402 1415 +13
- Misses 343 370 +27
|
Merged
timtreis
deleted the
bugfix/issue214-categorical-data-is-incorrectly-colored-in-the-legend-when-plotting-2
branch
| if (render_params.fill_alpha != render_params.outline_alpha) and render_params.contour_px is not None: | ||
| # First get the labels infill and plot them | ||
| # default case: no contour, just fill | ||
| # if fill_alpha and outline_alpha are the same, we're technically also at a no-outline situation |
There was a problem hiding this comment.
@timtreis Probably just an edge case, but if the user increases the outline width when fill_alpha == outline_alpha one would expect the labels to get bigger which would not happen since it's treated as no-outline, correct?
There was a problem hiding this comment.
hm, yes, that's true. Will send follow-up PR to cover this edge case. Good catch!
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor of #262 to avoid solving unneccecary merge conflicts due to age