-
Notifications
You must be signed in to change notification settings - Fork 17
add squidpy way to handle segment #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@sagar87 @timtreis this is a heavy rewrite of the rendering functions. It mostly focuses on aesthetics (colors, legend, colorbars, etc.) and doesn't change the core behavior of the library. With this current implementation I can showcase the aggregation functions in the notebooks but I'm afraid is not enough for the datasets you have been working on. I would however suggest to re-implement the functionalities in current logic. There are also 2 critical changes that need to be made (not in this PR).
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
it's ready! it should have almost all functionalities as before + handle of caterogical and continuous for points. Docstrings are missing, will try to finish them tomorrow. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 30.62% 40.34% +9.71%
==========================================
Files 12 9 -3
Lines 862 870 +8
==========================================
+ Hits 264 351 +87
+ Misses 598 519 -79
|
No description provided.