refactor: mark async storage and sovran as peer dependencies #734
Conversation
mateusz1913
force-pushed
the
refactor/async-storage-optional
branch
from
5ef026d to
a980691
Compare
Context: segmentio/sovran-react-native#44 In the README, the installation instructions point to install `@segment/sovran-react-native` & `@react-native-async-storage/async-storage`. In that case it doesn't make sense to include those as direct dependencies.
mateusz1913
force-pushed
the
refactor/async-storage-optional
branch
from
a980691 to
41fe1ad
Compare
mateusz1913
changed the title
|
👋 is there sth I need to improve here? |
|
Hi @mateusz1913 thanks for bringing this to our attention! It is definitely something we have considered and might take on in the future but we're not able to make this change at the moment. I'm going to close this out for now but please feel free to reach out with any additional concerns. |
|
Hi @alanjcharles, thx for reaching out. Is there any particular blocker that me (or anyone) can help resolve? |
|
@mateusz1913 we are planning to do this, but we need to fix it in sovran first too and we were in the middle of migrating the sovran repo. We're happy to convert them now that we have finished the migration. Thanks for your patience. @shamilovtim please refer to our code of conduct before posting. If you have actual issues, we're happy to take them on and prioritize them accordingly. Thanks. |
|
@alanjcharles You can see my comment in December relating to your team's lack of etiquette when it comes to open source ticket management. This is a constant across tickets, repos and projects. Interesting that you cynically deployed COC to silence a simple negative review. |
Context: Follow-up PR for segmentio/sovran-react-native#44
In the README, the installation instructions point to install
@segment/sovran-react-native&@react-native-async-storage/async-storage. In that case it doesn't make sense to include those as directdependencies.