This repository was archived by the owner on Mar 13, 2023. It is now read-only.
refactor: make async storage a peer dependency #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@segment/analytics-react-native` has an option to create custom persistor that matches `Persistor` type from `@segment/sovran-react-native`. If it's possible, then let's mark `@react-native-async-storage/async-storage` as optional peer dependency to not force users to download it when custom persistor is used. - `@react-native-async-storage/async-storage` is marked as optional peer dependency - `@react-native-async-storage/async-storage` is optionally required (instead of being imported) in `src/persistor/async-storage-persistor.ts`
mateusz1913
force-pushed
the
refactor/async-storage-optional
branch
from
539ef04 to
2980ba1
Compare
mateusz1913
added a commit
to mateusz1913/analytics-react-native
that referenced
this pull request
Dec 19, 2022
mateusz1913
added a commit
to mateusz1913/analytics-react-native
that referenced
this pull request
Dec 19, 2022
mateusz1913
added a commit
to mateusz1913/analytics-react-native
that referenced
this pull request
Dec 19, 2022
Context: segmentio/sovran-react-native#44 In the README, the installation instructions point to install `@segment/sovran-react-native` & `@react-native-async-storage/async-storage`. In that case it doesn't make sense to include those as direct dependencies.
|
👋 is there sth I need to improve here? |
|
@mateusz1913 Hey, nothing wrong with your PR, we just weren't tracking this repository lately. We just consolidated this in the monorepo at Thanks! |
|
Merged at: segmentio/analytics-react-native#779 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In my project, we use
@segment/analytics-react-native&@segment/sovran-react-nativeand we usereact-native-mmkv-storagefor key-value storage solution (including custom persistor for segment client). Recently we wanted to remove@react-native-async-storage/async-storageas it's not used in our codebase. However segment libraries declare it as adependency, even though it should be optional as@segment/analytics-react-nativehas an option to create custom persistor that matchesPersistortype from@segment/sovran-react-native.If it's possible, then let's mark
@react-native-async-storage/async-storageas optional peer dependency to not force users to download it when custom persistor is used.I'll make follow-up PR for
@segment/analytics-react-native@react-native-async-storage/async-storageis marked as optional peer dependency@react-native-async-storage/async-storageis optionally required (instead of being imported) insrc/persistor/async-storage-persistor.ts