-
Notifications
You must be signed in to change notification settings - Fork 197
fix: async-storage as optional peer dependency #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Makes `@react-native-async-storage/async-storage` and `react-native-get-random-values` as peer dependencies, async-storage is now optional in both core and sovran. PR by: [@mateusz1913](https://github.com/mateusz1913) - Remove sovran type exports. PR by: [@danychi](https://github.com/danychi) - Fixing jest setup for tests for mocking `UUID` and `react-native-get-random-values` for all tests by default. - Fixed the async-storage mock Co-authored-by: Mateusz Mędrek <[email protected]> Co-authored-by: Daniel Alarcón Amador <[email protected]>
Thanks @oscb – this is a fantastic improvement/re-organisation. Any idea when we can expect a release? Will this be a major release and/or require a minimum RN version? |
@isaachinman should be out before the end of the week! Quite possibly today or tomorrow if we can merge all fixes we want to go along with this change |
## [@segment/sovran-react-native-v1.0.1](https://github.com/segmentio/analytics-react-native/compare/@segment/sovran-react-native-v1.0.0...@segment/sovran-react-native-v1.0.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/sovran-react-native-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-v2.13.2](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.13.1...@segment/analytics-react-native-v2.13.2) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0)) * switching UUID library, new depedencies ([#772](#772)) ([4734389](4734389))
🎉 This PR is included in version @segment/analytics-react-native-v2.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-adjust-v0.6.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-adjust-v0.6.0...@segment/analytics-react-native-plugin-adjust-v0.6.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-adjust-v0.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-advertising-id-v1.2.2](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-advertising-id-v1.2.1...@segment/analytics-react-native-plugin-advertising-id-v1.2.2) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-advertising-id-v1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-amplitude-session-v0.3.2](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-amplitude-session-v0.3.1...@segment/analytics-react-native-plugin-amplitude-session-v0.3.2) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-amplitude-session-v0.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-appsflyer-v0.5.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-appsflyer-v0.5.0...@segment/analytics-react-native-plugin-appsflyer-v0.5.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-appsflyer-v0.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-branch-v1.0.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-branch-v1.0.0...@segment/analytics-react-native-plugin-branch-v1.0.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-branch-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @segment/analytics-react-native-plugin-braze-middleware-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-braze-v0.5.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-braze-v0.5.0...@segment/analytics-react-native-plugin-braze-v0.5.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-braze-v0.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-destination-filters-v1.0.2](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-destination-filters-v1.0.1...@segment/analytics-react-native-plugin-destination-filters-v1.0.2) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-destination-filters-v1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-facebook-app-events-v0.5.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-facebook-app-events-v0.5.0...@segment/analytics-react-native-plugin-facebook-app-events-v0.5.1) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-facebook-app-events-v0.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-firebase-v0.3.5](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-firebase-v0.3.4...@segment/analytics-react-native-plugin-firebase-v0.3.5) (2023-03-14) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0)) * move firebase to peer dependency ([#782](#782)) ([6a6f1cd](6a6f1cd)) * switching UUID library, new depedencies ([#772](#772)) ([4734389](4734389))
@oscb was If it is intended to be a minor or major patch, then my understanding is there is also a required change to the core library's dependencies, as it is still listed as Am currently trying to include this fix in my repo, but |
@Alex-McLean @oscb Same issue here. Setting resolutions works as a temporary fix:
Clearly this shows that the repo is missing any sort of functional testing in its deploy/release pipeline. |
@Alex-McLean yea, that was a mistake. It is the first release of that package from this monorepo, so @isaachinman the monorepo does run functional integration tests against the example app, but it uses module resolutions to resolve and test the code to the commit being released. I'm guessing we could bump versions and deploy to a local registry, then install dependencies from there so that we could spot version bump mismatches before actually releasing to the public NPM Registry, but curious if you have any suggestions. |
## [@segment/analytics-react-native-plugin-idfa-v0.6.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-idfa-v0.6.0...@segment/analytics-react-native-plugin-idfa-v0.6.1) (2023-03-15) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
🎉 This PR is included in version @segment/analytics-react-native-plugin-idfa-v0.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [@segment/analytics-react-native-plugin-idfa-v0.6.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-plugin-idfa-v0.6.0...@segment/analytics-react-native-plugin-idfa-v0.6.1) (2023-03-15) ### Bug Fixes * async-storage as optional peer dependency ([#779](#779)) ([f3d5bc0](f3d5bc0))
@react-native-async-storage/async-storage
andreact-native-get-random-values
as peer dependencies, async-storage is now optional in both core and sovran. PR by: @mateusz1913UUID
andreact-native-get-random-values
for all tests by default.Co-authored-by: Mateusz Mędrek [email protected]
Co-authored-by: Daniel Alarcón Amador [email protected]