Bugfix release v3.0.1 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #143 where we are trying to read a subsection of config section passed as parameter
but user tries to invoke a config method accepting a `IConfiguration`so that it is obvious that something is wrong. Probably accidentally fixes another issue
Do not access "Serilog" sub-section when calling ReadFrom.ConfigSection / properly populate `IConfiguration` in configuration methods
In that case, the default value of the param will be passed
|
When #149 gets merged, we may be in a good spot to publish a bugfix release v3.0.1, what do you think ? |
|
I'll be on the road and email-only until Sunday, so I can't look at anything in-depth. Sounds like the right thing to do, though. |
No longer throw when calling a method with optional IConfiguration param
|
Awesome :-) 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few bugs in v3.0.0. It would be nice to publish a release with the fixes quickly :)
IConfigurationparameters not populatedReadFrom.ConfigSectionexpects nested section underSerilogsectionSee discussion in #144 (comment)