Skip to content

No longer throw when calling a method with optional IConfiguration param #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

tsimbalar
Copy link
Member

@tsimbalar tsimbalar commented Oct 16, 2018

In that case, the default value of the param will be passed

This PR completed the parts I missed in #144

Based on comment #148 (comment) by @MV10 , an edge case was not tested ... it is now covered and fixed !

In that case, the default value of the param will be passed
@tsimbalar tsimbalar merged commit 3834bda into serilog:dev Oct 17, 2018
@tsimbalar tsimbalar deleted the bugfix/nullable-iconfig branch October 17, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant