Fix finding UIScrollViews that are clipped(), masked or combined with clipShape() or cornerRadius()

[paescebu]

This should fix issue:
issues 162

Fixes:

struct ContentView: View {
    var body: some View {
        HStack {
            ScrollViewReader { proxy in
                ScrollView(.horizontal) {
                    TimeLineView()
                }
                .introspectScrollView { scrollView in
                    print(scrollView)    //closure not called when clipped or masked
                }
                .clipped()              // this caused issues
                .mask(Text("Hello"))    // or this
                .clipShape(Rectangle()) // and this
            }
        }
    }
}

[kaweerutk]

lgtm

[davdroman]

This breaks CI in every platform for testNestedScrollView. We can't merge this until that test is fixed.

[paescebu]

This breaks CI in every platform for testNestedScrollView. We can't merge this until that test is fixed.

You're right. The test is also correct though. It seems that this change breaks the logic as soon as two ScrollViews are in play (either on the same level, or nested).
IMO its not the tests that need to be fixed, it's the implementation itself

[paescebu]

I think I found a solution, but I feel the name of the new selector is quite verbose. Because first i will search through the hierarchy that was looked through before, and only if it doesn't find the respective ScrollView I apply the selector that goes higher up to its ancestors. Changes pushed

Let me know how this can be improved

[paescebu]

I also added a unit test that validates that masked or clipped ScrollViews are also found correctly. (unit tests "correctly" fail if the change is reverted)

[davdroman]

IMO its not the tests that need to be fixed, it's the implementation itself

You're right, I misspoke 😄

[davdroman]

Great effort, @paescebu 👏

[paescebu]

thank you @davdroman!
It's my first contribution to another open source library :D Happy to help