Skip to content

Fix finding UIScrollViews that are clipped(), masked or combined with clipShape() or cornerRadius() #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2023
Merged

Fix finding UIScrollViews that are clipped(), masked or combined with clipShape() or cornerRadius() #213

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2a7bbf
fix finding ScrollViews that are clipped, masked or combined with cli…
Apr 5, 2023
98c3236
search ScrollViews in flatter hierarchy first
paescebu May 12, 2023
603c951
Add unit tests for masked scroll views use cases
paescebu May 12, 2023
d2fa09e
renamed selector (duplicate "Ancestor" in it's name)
paescebu May 12, 2023
5446bda
Merge branch 'master' into master
davdroman May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Introspect/ViewExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ extension View {
/// Finds a `UIScrollView` from a `SwiftUI.ScrollView`, or `SwiftUI.ScrollView` child.
public func introspectScrollView(customize: @escaping (UIScrollView) -> ()) -> some View {
if #available(iOS 14, tvOS 14, *) {
return introspect(selector: TargetViewSelector.siblingOfTypeOrAncestor, customize: customize)
return introspect(selector: TargetViewSelector.siblingContainingOrAncestorOrAncestorChild, customize: customize)
} else {
return introspect(selector: TargetViewSelector.siblingContainingOrAncestor, customize: customize)
}
Expand Down